sinon-mongoose icon indicating copy to clipboard operation
sinon-mongoose copied to clipboard

Published 20 hours ago • verified publisher icon Nubescope

Upgrade of mongoose to +5.5.x

Open YasharF opened this issue 6 years ago • 5 comments

Upgrade of mongoose was omitted from https://github.com/underscopeio/sinon-mongoose/pull/46 even though npm audit calls it out to have an issue. I did make an attempt to do the upgrade in package.json, but it looks like that there is a breaking change and it causes npm test to fail.

YasharF avatar Apr 08 '19 20:04 YasharF

Thanks for reporting this. Let me know if you've some more info about it.

gaguirre avatar Apr 22 '19 02:04 gaguirre

By some trial and error when running npm test, I have narrowed that 5.3.16 -> 5.4.0 is the breaking change. The three tests that failed are the "verify chained" tests.

Here is the changelog for mongoose at that point: https://github.com/Automattic/mongoose/blob/master/History.md#540--2018-12-14

YasharF avatar Apr 22 '19 14:04 YasharF

With https://github.com/underscopeio/sinon-mongoose/pull/49 mongoose is getting bumped to 5.3.16 by the way.

YasharF avatar Apr 22 '19 16:04 YasharF

I'll work on this

dhuang612 avatar Oct 21 '19 03:10 dhuang612

Hi,

I created PR #53 with all tests working now. Thanks

dhuang612 avatar Oct 21 '19 21:10 dhuang612