sinon-mongoose icon indicating copy to clipboard operation
sinon-mongoose copied to clipboard

Removal of unmaintained dependencies

Open YasharF opened this issue 6 years ago • 3 comments

gulp-coveralls is no longer being maintained https://github.com/underscopeio/sinon-mongoose/pull/46 is moving sinon-mongoose's dependency to a maintained fork, but in the long run, it might be worth looking into an alternative that is better maintained or perhaps remove the dependency altogether.

isparta is no longer being maintained The repo is marked with the badge http://unmaintained.tech For code quality and to reduce npm audit issues I would recommend either to just remove the dependency or find an alternative

gulp-istanbul / istanbul is no longer being maintained istanbul's deprecation message: "This module is no longer maintained, try this instead: npm i nyc Visit https://istanbul.js.org/integrations for other alternatives." -- source: npm: istanbul.

YasharF avatar Apr 08 '19 20:04 YasharF

Totally agree. To be honest, I'm not actively maintaining this package (I mean, keeping it updated with latests tools, etc) so any PR is welcome.

gaguirre avatar Apr 22 '19 02:04 gaguirre

Removal of gulp-coveralls and (no longer needed) babel: https://github.com/underscopeio/sinon-mongoose/pull/49

YasharF avatar Apr 22 '19 16:04 YasharF

Looking at dealing with gulp-istanbul which causes the istanbul deprecation warning, and taking a step back, after https://github.com/underscopeio/sinon-mongoose/pull/49 what gulp is still doing is:

  • eslint check
  • code coverage report
  • execute tests using gulp-mocha

With the latest/current npm, mocha, and nyc (istanbul cli replacement) these could be achieved without gulp, enabling removal of the dependencies on all of the gulp plugins such as gulp-istanbul which causes deprecation warnings. This can also eliminate the issue with isparta. More specifically, eslint can run as a mocha task, and:

  "scripts": {
    "test": "gulp"
  },

needs to get replaced with

  "scripts": {
    "test": "nyc mocha --timeout=10000 --exit"
  },

I can submit a separate PR after https://github.com/underscopeio/sinon-mongoose/pull/49 or combine it in the same PR. Let me know.

YasharF avatar May 29 '19 16:05 YasharF