NuGet.Client icon indicating copy to clipboard operation
NuGet.Client copied to clipboard

Avoid need to sort sequences to compare equality.

Open Erarndt opened this issue 1 year ago • 4 comments

Bug

Fixes: https://github.com/NuGet/Home/issues/13247

Regression? Last working version:

Description

Improves performance and reduces allocations when checking lists for equality.

PR Checklist

  • [x] PR has a meaningful title

  • [x] PR has a linked issue.

  • [x] Described changes

  • Tests

    • [ ] Automated tests added
    • OR
    • [x] Test exception
    • OR
    • [ ] N/A
  • Documentation

    • [ ] Documentation PR or issue filled
    • OR
    • [x] N/A

Erarndt avatar Dec 08 '23 21:12 Erarndt

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

ghost avatar Dec 27 '23 22:12 ghost

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

ghost avatar Jan 16 '24 19:01 ghost

@Erarndt some tests are failing with this change https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9173771&view=ms.vss-test-web.build-test-results-tab&runId=95788042&resultId=112702&paneView=debug

jeffkl avatar Mar 01 '24 20:03 jeffkl

Team Review: Closing this PR for now

jeffkl avatar Jun 25 '24 22:06 jeffkl