Android-nRF-Connect-Device-Manager icon indicating copy to clipboard operation
Android-nRF-Connect-Device-Manager copied to clipboard

Published 20 hours ago • verified publisher icon NordicSemiconductor

Add stream variants for download and upload in FsManager

Open obermillerk opened this issue 1 year ago • 1 comments

Implementation to resolve #157

I added separate stream versions of transfer classes so that backwards compatibility is not affected. I did have to make a small addition to Transfer so that retrieving the total size of the transfer in TransferCallable does not depend on retrieving the data array to allow it to work with stream versions.

obermillerk avatar Jun 06 '24 16:06 obermillerk

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 06 '24 16:06 CLAassistant

This is so cool! I was looking forward to this kind of thing because it's perfectly conceivable for our team to need this sort of functionality in the not-so-distant future. Thumbs up mate!

ksidirop-laerdal avatar Aug 21 '24 09:08 ksidirop-laerdal

I'll merge the PR and release as 2.1. I have not tested it, trusting you did :)

philips77 avatar Sep 06 '24 13:09 philips77

Yes, we've been using a privately published version with this, works great! Thanks for merging

obermillerk avatar Sep 12 '24 23:09 obermillerk

Side-question: For the sake of symmetry is it possible to replicate this feature on the iOS side? (I'm not an expert in Swift but I can give it a shot if you want some help getting the effort off the ground)

Let me know what you think. @philips77

ksidirop-laerdal avatar Sep 13 '24 10:09 ksidirop-laerdal

Sure, that would help us a lot! I'll cc @dinesharjani here, as he's looking after the iOS version.

philips77 avatar Sep 16 '24 12:09 philips77