dynamic_theme icon indicating copy to clipboard operation
dynamic_theme copied to clipboard

Issue #63

Open TesteurManiak opened this issue 3 years ago • 6 comments
trafficstars

Fix #63

  • Changed version number to 2.0.0
  • Migration to null-safety (Fix #62, Fix #60, Fix #59)
  • Now use the ThemeMode instead of Brightness (Fix #49).
  • ThemedWidgetBuilder themedWidgetBuilder takes now the following parameters: BuildContext, ThemeMode, ThemeData.
  • data parameter is now optional and has the type ThemeDataWithThemeModeBuilder.
  • defaultBrightness became defaultThemeMode and use by default ThemeMode.system.
  • loadBrightnessOnStart became loadThemeOnStart.
  • import package:dynamic_theme/dynamic_theme.dart for both DynamicTheme and BrightnessSwitcherDialog.

TesteurManiak avatar Dec 14 '21 08:12 TesteurManiak

Nice work Guillaume!

I'm trying to install your fork, but I have this error: Because every version of dynamic_theme from git depends on shared_preferences >=2.0.8 which requires SDK version >=2.14.0 <3.0.0, dynamic_theme from git is forbidden.

My company project has Dart >=2.12. Could you downgrade shared_preferences to 2.0.7?

I suggest you to make another version of this package that supports Dart >=2.14

guillempuche avatar Dec 20 '21 09:12 guillempuche

Hi @guillempuche, I've changed the dependency from shared_preferences: ^2.0.9 to shared_preferences: ">=2.0.0 <3.0.0" which should fix your issue. Note that you can also use dependency_overrides in your pubspec.yaml to force the use of a specific version of shared_preferences:

dependencies:
  # my dependencies
dependency_overrides:
  shared_preferences: 2.0.7

TesteurManiak avatar Dec 20 '21 10:12 TesteurManiak

Thanks a lot for sharing your knowledge, Guillaume!

guillempuche avatar Dec 20 '21 13:12 guillempuche

@Norbert515, could you update the package?

guillempuche avatar Nov 10 '22 08:11 guillempuche

@Norbert515, could you merge this, please?

jackbrown1993 avatar Feb 12 '23 17:02 jackbrown1993

+1 @Norbert515

freemansoft avatar Jun 28 '23 01:06 freemansoft