hardhat-vscode icon indicating copy to clipboard operation
hardhat-vscode copied to clipboard

Find all Implementations on an interfaces needs defined

Open kanej opened this issue 3 years ago • 1 comments
trafficstars

If you trigger "Find all implementations" on the name of an interface declaration, we show all the references for the implementation including the originating interface:

image

There are two issues here:

  • Find all implementations is really just find all references - it is not building up the inheritance tree and giving results based on that
  • there is a question of what is the right thing to do - should all children of the interface/contract be shown, or just the immediate children in the hierarchy

The final implementation should:

  • deal with interfaces extending other interfaces
  • deal with abstract contracts
  • exclude the originating interface/contract from the "implementations list"

kanej avatar Feb 11 '22 11:02 kanej

I suspect we should focus our efforts on slangs usedef work to resolve this.

kanej avatar Jan 02 '23 17:01 kanej