ofborg icon indicating copy to clipboard operation
ofborg copied to clipboard

Add inline comments for missing maintainer, homepage, changelog, license fields

Open davidak opened this issue 6 years ago • 3 comments
trafficstars

Just a reminder that:

Ofborg could and should send inline comments suggesting filling out maintainer, homepage, change log, license fields.

Source: https://github.com/NixOS/nixpkgs/pull/60371#issuecomment-487401724

davidak avatar Nov 08 '19 22:11 davidak

Also maybe nice would be to check if the website is actually available. And if it is, it would be cool to assure that it is included in the internet archive. Though I'm not entirely sure what their stance on automated saving is.

timokau avatar Nov 09 '19 11:11 timokau

@timokau problems with the website are also detected by repology. Maybe that's enough?

davidak avatar Nov 09 '19 19:11 davidak

It would certainly be nicer if ofBorg could already detect it in the offending PR. For example if changelog = https://some-webpage.com/${version} it would immediately notice if there was no changelog for ${version} and the PR author could check if the changelog moved.

timokau avatar Nov 09 '19 23:11 timokau