nixos-hardware icon indicating copy to clipboard operation
nixos-hardware copied to clipboard

Move battery options to non-asus specific folder

Open fidgetingbits opened this issue 1 year ago • 5 comments

Description of changes

The current asus/battery.nix file isn't actually asus-specific, and seems useful to be used by other non-asus laptops. This moves it into a generic folder common/pc/laptop/ and updates the current users.

Since there was also an option hardware.asus.battery, this deprecates the old option and changes to new hardware.battery instead.

I tested that the deprecation warning works if hardware.asus.battery.chargeUpTo = 50; is set somewhere. I also ran the test script against the three updated asus laptops to ensure they pass.

I have not actually tested the changes on a live machine.

Things done
  • [x] Tested the changes in your own NixOS Configuration
  • [ ] Tested the changes end-to-end by using your fork of nixos-hardware and importing it via <nixos-hardware> or Flake input

fidgetingbits avatar Jun 04 '24 00:06 fidgetingbits