nixos-hardware icon indicating copy to clipboard operation
nixos-hardware copied to clipboard

Use `fdprintd-thinkpad` on thinkpads

Open Synthetica9 opened this issue 6 years ago • 2 comments

https://github.com/NixOS/nixos-hardware/blob/59c97be4d0c9e859cb8e3d214707601f213a6914/lenovo/thinkpad/default.nix#L9

Shouldn't services.fprintd.package also be set to fdprintd-thinkpad? (Introduced in https://github.com/NixOS/nixpkgs/pull/61546)

CC @Cizra

Synthetica9 avatar May 23 '19 07:05 Synthetica9

Possibly. I've only tested it on Lenovo P50, which might be different from other ThinkPads.

It's fprintd-thinkpad, not fdprint-thinkpad.

ghost avatar May 23 '19 08:05 ghost

This package is so undocumented that I thought nixpkgs could have been compromised.

I can't find the software homepage by a search of libfprint-thinkpad online: I had to open the source of the package to figure out it's https://github.com/3v1n0/libfprint. I think this is because the name was made up by a nixpkgs contributor, as the software as no official name. The README.md doesn't exactly explain what it is either, I guess it's a fork to support a specific reader (Validity 138a:0090?), who maintains it and whether they are affiliated with the devs of libfprint (apparently they are).

Anyway, it should be used only on recent thinkpad.

rnhmjoj avatar Mar 03 '20 20:03 rnhmjoj