framework: refactor kmod for improved AMD support

[xeniarose]

Description of changes

Fixes #1028

Changes several aspects of framework-laptop-kmod support:

• default value has been changed to true when NixOS >= 24.05 and linux kernel >=6.10; false otherwise
• adds required patch for framework AMD enablement when kernel <6.10
• add README section describing usage

Also: this may be an upstream nixpkgs issue, but the lack of a good lore.kernel.org fetcher is kind of surprising. I tried using this sample code with fetchpatch initially, but got weird errors with it. I implemented a fetchb4 fetcher for my own personal usage, which uses b4 to download and format patches from https://lore.kernel.org and the skeleton of that is present in this PR using runCommand for simplicity

Things done

• [x] Tested the changes in your own NixOS Configuration
• [x] Tested the changes end-to-end by using your fork of nixos-hardware and importing it via <nixos-hardware> or Flake input

Edit: I've been running this on my own framework 16 for a bit now and everything seems to be working fine

[nyabinary]

Bump :p

[nyabinary]

kmod is not needed anymore in the upcoming kernels btw

[paperdigits]

The kernel now fails to build with 6.11.

[llakala]

The kernel now fails to build with 6.11.

There was a patch yesterday that landed on stable and unstable that makes it work on 6.11. Should be fine now, it's working on my machine.

[paperdigits]

Awesome I will give it another go today. Thanks!

On September 21, 2024 8:34:16 AM PDT, quatquatt @.***> wrote:

The kernel now fails to build with 6.11.

There was a patch yesterday that landed on stable and unstable that makes it work on 6.11. Should be fine now, it's working on my machine.

-- Reply to this email directly or view it on GitHub: https://github.com/NixOS/nixos-hardware/pull/1029#issuecomment-2365229083 You are receiving this because you commented.

Message ID: @.***>

[Mic92]

What is the reason this is marked as draft?

[xeniarose]

What is the reason this is marked as draft?

it looks like you marked it as a draft during the review comments. if you think those issues still need to be addressed in some way, i'm happy to make further changes. otherwise, it would be fine to remove the draft status -- it doesn't look like i can do it myself

my personal daily laptop is running nixos-hardware from my own branch here and at this point it's been working with no issues for >6 months. my use case was solely to get the battery charge limit showing up in KDE, so i could extend my battery lifespan

[Mic92]

@mergify queue

[mergify[bot]]

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at ce98bebf0f98140cb1d4b6a3edee4f1eaade9261