nacre icon indicating copy to clipboard operation
nacre copied to clipboard

add compatibility with docker

Open Romain7495 opened this issue 3 years ago • 1 comments

Hello,

I just start a PR to add docker compatibility. You can now start a javascript (nacre) script on entrypoint. The goal is also to facilitate contibutate to the repo without taking care of node version and your personnal environment. I still need to update documentation and maybe github action to publish an image to docker hub with your consent :)

Feel free to merge :D

Romain7495 avatar Jun 27 '22 15:06 Romain7495

Hi @Romain7495 , Thanks for your PR, there are few things in here:

1. Facilitate the development for contributions

without taking care of node version and your personnal environment.

I would recommend using nvm for this, it appears to me less cumbersome than spinning an entire docker. Nevertheless, having a Dockerfile to run test would be handy, especially for the windows based contributors looking for testing Nacre against linux (faster feedback than waiting for CI pipeline).

2. Nacre Docker image for end users

This would require a bit of work, I can at least see:

  1. the build of the docker image to be tested
  2. the release of the docker image should happen at the same time as the npm release
  3. the docker image tagged with the same version as the npm version

3. Package-lock

I am good at introducing the package-lock and update our pipeline using npm ci 👍 (and later in our Dockerfile)

==========

To me, 2. seems a bit of work for the benefits right now. I would wait for the end of the Beta to invest time personally in this direction but feel free in a separate PR! For this PR I would focus on 1. and 2.

Ninroot avatar Jun 30 '22 09:06 Ninroot