nginx-proxy-manager
nginx-proxy-manager copied to clipboard
force-ssl behind another proxy using http_x_forwarded_proto
Fix for issue #3365 and pull request #3589
Change looks good, can you confirm that this docker image works as you expect?
Seems like is working as expected, but maybe some additional tests with configurations a bit more elaborated than mine will be a good idea.
This doesn't work when you have Cloudflare Tunnel (cloudflared) connecting to an https nginx endpoint and they requested HTTP.
The working code changes this:
if ($http_x_forwarded_proto = "https") {
set $test "";
}
to this:
if ($http_x_forwarded_proto = "http") {
set $test "H";
}
It then works as expected.
PR is now considered stale. If you want to keep it open, please comment :+1:
Docker Image for build 8 is available on DockerHub:
nginxproxymanager/nginx-proxy-manager-dev:pr-3819
[!NOTE] Ensure you backup your NPM instance before testing this image! Especially if there are database changes. This is a different docker image namespace than the official image.
[!WARNING] Changes and additions to DNS Providers require verification by at least 2 members of the community!