matnwb icon indicating copy to clipboard operation
matnwb copied to clipboard

Refactor dynamic table

Open ehennestad opened this issue 1 year ago • 2 comments

Motivation

PR #543 (Convert Azure Pipelines to GitHub actions) contained several changes to the dynamic table interface. In order to keep a clear separation of concerns, I wanted to separate all code changes related to dynamic table refactoring into a separate (this) PR.

Checklist

  • [x] Have you ensured the PR description clearly describes the problem and solutions?
  • [x] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • [x] If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

ehennestad avatar Nov 02 '24 08:11 ehennestad

@lawrence-mbf Would you mind giving a brief overview of the motivation for the changes in this PR?

ehennestad avatar Nov 02 '24 08:11 ehennestad

Codecov Report

Attention: Patch coverage is 85.83333% with 34 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (6717aa1) to head (07b746d). Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
+types/+util/+dynamictable/addVarargColumn.m 73.17% 22 Missing :warning:
+types/+util/getVectorClassName.m 60.86% 9 Missing :warning:
+types/+util/+dynamictable/addColumn.m 94.44% 1 Missing :warning:
+types/+util/+dynamictable/addRawData.m 92.30% 1 Missing :warning:
+types/+util/+dynamictable/getIndex.m 97.56% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   90.63%   90.18%   -0.46%     
==========================================
  Files         106      107       +1     
  Lines        4689     4767      +78     
==========================================
+ Hits         4250     4299      +49     
- Misses        439      468      +29     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 02 '24 08:11 codecov[bot]

Closing this @bendichter @lawrence-mbf. It is stale, and there is no reference describing what changes are made or why.

ehennestad avatar Jun 18 '25 10:06 ehennestad