matnwb icon indicating copy to clipboard operation
matnwb copied to clipboard

588 Add check on file export to ensure all required properties are filled out

Open ehennestad opened this issue 1 year ago • 1 comments

Fix #588

Motivation

Check that all required properties are filled out before nwb file is exported

How to test the behavior?

nwb=NwbFile();
nwbExport(nwb, 'test.nwb')

Checklist

  • [ ] Have you ensured the PR description clearly describes the problem and solutions?
  • [ ] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • [ ] If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

ehennestad avatar Sep 21 '24 18:09 ehennestad

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.90%. Comparing base (5cd6af6) to head (99d8b42). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   90.56%   90.90%   +0.34%     
==========================================
  Files         107      107              
  Lines        4695     4751      +56     
==========================================
+ Hits         4252     4319      +67     
+ Misses        443      432      -11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 21 '24 19:09 codecov[bot]

@bendichter Some fixes to the workflows from the previous PR got included here.

ehennestad avatar Nov 02 '24 16:11 ehennestad