matnwb icon indicating copy to clipboard operation
matnwb copied to clipboard

[Feature]: Issue warning if adding starting_time_rate w/o starting_time for TimeSeries

Open ehennestad opened this issue 1 year ago • 0 comments

What would you like to see added to MatNWB?

If the starting_time_rate property of a types.core.TimeSeries object is set while the starting_time is unset, the starting_time_rate is not actually written to file, but there is no indication from matnwb that this is not happening.

There should be a warning if the value of starting_time_rate is set and the value of starting_time is empty for a TimeSeries object.

This also needs to be fixed in the Behavior tutorial. That tutorial creates multiple TimeSeries or TimeSeries derived objects and sets the starting_time_rate, but not the starting_time. The result is a file without starting_time/starting_time_rate which can not be opened in pynwb.

Is your feature request related to a problem?

Yes, See above

What solution would you like?

  • [ ] Add warning in set method for starting_time_rate if value of starting_time is empty
  • [ ] Add value for starting_time when creating TimeSeries objects in the Behavior tutorial

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

ehennestad avatar Sep 01 '24 11:09 ehennestad