moabb icon indicating copy to clipboard operation
moabb copied to clipboard

Parametrisation of n_component in CCA based SSVEP classification

Open emmanuelkalunga opened this issue 2 years ago • 2 comments
trafficstars

Hi @sylvchev, In the the current implementation of the SSVEP CCA classification, CCA classifiers are instantiated with the number of CCA components fixed to one i.e. n_components = 1.
The number of components does affect the performance of CCA-based classifiers significantly. I would like to change that in all CCA classifiers (present and futures) so that n_components can be passed as a parameter. What do you think?

P.S. I am referring to the implementations in moabb/moabb/pipelines/classification.py

emmanuelkalunga avatar Apr 12 '23 20:04 emmanuelkalunga

Ok, definitely a must. We could include it in the PR #359 We need to add an admonition in the docstring to indicate this change, like the example below:

    Notes
    -----
    .. versionadded:: 0.4.7

sylvchev avatar Apr 13 '23 06:04 sylvchev

Ok. I will add it to the PR

emmanuelkalunga avatar Apr 13 '23 06:04 emmanuelkalunga