sedge
sedge copied to clipboard
fix #521 - validator-blocker: add missing $ sign
Fixes #521
Changes:
- Added the missing $ sign (To enable the correct escape sequence) to the ENTRYPOINT script in the generated docker-compose for validator-blocker deployment.
Types of changes
What types of changes does your code introduce?
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Other (please describe):
Testing
Requires testing
- [ ] Yes
- [x] No
In case you checked yes, did you write tests?
- [ ] Yes
- [x] No
Comments about testing , should you have some (optional)
Tested it localy on my mac machine as well as a VM with Ubuntu as a base image and the validator-blocker was configured correctly and succesfully exited when the depending deployments/healthcheck to validator response was 200 (OK).
Further comments (optional)
Not a complex PR, really simple fix and probably mergable/ready for merge.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 24.13%. Comparing base (0ae4840) to head (5dd0366).
Additional details and impacted files
@@ Coverage Diff @@
## develop #522 +/- ##
========================================
Coverage 24.13% 24.13%
========================================
Files 121 121
Lines 19672 19672
========================================
Hits 4748 4748
Misses 14380 14380
Partials 544 544
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 24.13% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.