sedge
sedge copied to clipboard
JWTsecret to relative path
Changes:
- When not provided, the jwt secret is set as a relative path. This allows users to share their setup more easily.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Other (please describe):
Testing
Requires testing
- [x] Yes
- [ ] No
In case you checked yes, did you write tests?
- [x] Yes
- [ ] No
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Codecov Report
Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.
Project coverage is 24.76%. Comparing base (
6ab41db) to head (f9c741c).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| cli/actions/jwt_secrets.go | 38.46% | 5 Missing and 3 partials :warning: |
| cli/generate.go | 70.00% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #484 +/- ##
===========================================
- Coverage 24.78% 24.76% -0.02%
===========================================
Files 120 120
Lines 22313 22331 +18
===========================================
Hits 5530 5530
- Misses 16241 16253 +12
- Partials 542 548 +6
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 24.76% <52.17%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.