sedge icon indicating copy to clipboard operation
sedge copied to clipboard

Integrate lido-exporter into the monitoring stack

Open khalifaa55 opened this issue 1 year ago • 1 comments

Changes:

  • Add lido-exporter as a service to the monitoring stack.
  • Update sedge cli with prompt to enable default monitoring stack configuration.
  • Update sedge monitoring command to have default and lido subcommands to enable different monitoring stack configurations.
  • Adjust monitoring stack docker-compose setup to use templates (similar to sedge generation setup).

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [x] Yes
  • [ ] No

In case you checked yes, did you write tests?

  • [x] Yes
  • [ ] No

khalifaa55 avatar Sep 25 '24 16:09 khalifaa55

Codecov Report

Attention: Patch coverage is 67.38197% with 76 lines in your changes missing coverage. Please review.

Project coverage is 44.71%. Comparing base (d45ab87) to head (df93ac9).

Files with missing lines Patch % Lines
internal/monitoring/monitoring.go 58.62% 18 Missing and 18 partials :warning:
...ernal/monitoring/services/lido_exporter/service.go 67.56% 10 Missing and 2 partials :warning:
cli/cli.go 60.71% 6 Missing and 5 partials :warning:
internal/monitoring/data/monitoring.go 33.33% 6 Missing and 4 partials :warning:
cli/monitoring.go 92.98% 2 Missing and 2 partials :warning:
cmd/sedge/main.go 0.00% 3 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
+ Coverage    44.34%   44.71%   +0.37%     
===========================================
  Files          114      115       +1     
  Lines         9797     9992     +195     
===========================================
+ Hits          4344     4468     +124     
- Misses        4991     5031      +40     
- Partials       462      493      +31     
Flag Coverage Δ
unittests 44.71% <67.38%> (+0.37%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 25 '24 17:09 codecov-commenter