sedge icon indicating copy to clipboard operation
sedge copied to clipboard

Add Grandine Consensus client support

Open khalifaa55 opened this issue 1 year ago • 3 comments

Closes #381

Changes:

  • Add Grandine Consensus and Validator client to network Mainnet.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [x] Yes
  • [ ] No

In case you checked yes, did you write tests?

  • [ ] Yes
  • [x] No

khalifaa55 avatar May 19 '24 23:05 khalifaa55

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.59%. Comparing base (398245d) to head (9b76264).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #383   +/-   ##
========================================
  Coverage    86.59%   86.59%           
========================================
  Files           78       78           
  Lines         3977     3977           
========================================
  Hits          3444     3444           
  Misses         448      448           
  Partials        85       85           
Flag Coverage Δ
unittests 86.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 19 '24 23:05 codecov-commenter

putting that for test with Nethermind client :)

kamilchodola avatar May 21 '24 08:05 kamilchodola

@khalifaa55 Seems like it didn't worked for me: ./sedge generate --logging none -p /root full-node --map-all --no-mev-boost --no-validator --network mainnet -e nethermind:nethermindeth/nethermind:master -c grandine:sifrai/grandine:stable

kamilchodola avatar May 21 '24 08:05 kamilchodola