security_monkey icon indicating copy to clipboard operation
security_monkey copied to clipboard

Published 20 hours ago • verified publisher icon Netflix

Seeing duplicate revisions

Open cstewart87 opened this issue 8 years ago • 2 comments
trafficstars

We're seeing duplicate revisions in many of our items. We may have found the issue, but it might take some time to get a PR reviewed. If someone can repro and submit a fix, that would be awesome!

https://github.com/Netflix/security_monkey/blob/develop/security_monkey/datastore.py#L573 adds a new revision, but shouldn't because https://github.com/Netflix/security_monkey/blob/develop/security_monkey/datastore.py#L551-L557 handles revision updates (specifically revisions for ephemeral changes).

cstewart87 avatar Jan 25 '17 16:01 cstewart87

@cstewart87 - Was this addressed?

scriptsrc avatar Apr 14 '17 16:04 scriptsrc

Hey @monkeysecurity! I had to refresh, and after looking at the code, it looks like this may no longer be the case. Well, the code has changed in recent releases, at least.

The original issues were here:

  • https://github.com/Netflix/security_monkey/blob/c666a012ec65a4ffcb878d148e2af33022c42afd/security_monkey/datastore.py#L573 (adds new revision, but shouldn't)
  • https://github.com/Netflix/security_monkey/blob/c666a012ec65a4ffcb878d148e2af33022c42afd/security_monkey/datastore.py#L551-L557 (handles revision updates for ephemeral changes)

I'm no longer on the project, but it might be worth reaching out to @kalpatel01 to see if he's still seeing this issue.

cstewart87 avatar Apr 14 '17 17:04 cstewart87