metaflow icon indicating copy to clipboard operation
metaflow copied to clipboard

Add GH tests for all supported versions of Python and R

Open savingoyal opened this issue 3 years ago • 4 comments

Metaflow currently supports Py>=3.4 (with limited support for Py2.7) and R>=3.8. The GH tests only test for Py3.7 and R4.1. We should ensure we test on the whole set of permutations.

savingoyal avatar Jan 25 '22 18:01 savingoyal

@oavdeev FYI - for a similar setup for BuildKite.

savingoyal avatar Jan 25 '22 18:01 savingoyal

Trying this here

hamelsmu avatar Feb 01 '22 06:02 hamelsmu

I'm able to get tests to pass for

Python:

  • 3.6 to 3.9 on ubuntu
  • 3.7 to 3.9 on macos

R

  • 4.0 and 4.1.1 on ubuntu and macos

@savingoyal do we want all tests to pass before opening a PR? Some tests are breaking for example because of the presence of f-strings, should I submit a PR for the ranges that pass only and then worry about expanding it from there?

image

image

hamelsmu avatar Feb 01 '22 07:02 hamelsmu

Looks like this one can be closed by https://github.com/Netflix/metaflow/pull/946?

tfurmston avatar Sep 04 '22 06:09 tfurmston