metaflow icon indicating copy to clipboard operation
metaflow copied to clipboard

Docstring for AwsSecretsManagerSecretsProvider is incorrect

Open dendraR2 opened this issue 1 year ago • 2 comments

The docstring for class AwsSecretsManagerSecretsProvider(SecretsProvider) says

 If the secret contains a string payload ("SecretString"):
        - if the `parse_secret_string_as_json` option is True (default):
            {SecretString} will be parsed as a JSON. If successfully parsed, AND the JSON contains a
            top-level object, each entry K/V in the object will also be converted to an entry in the result. V will
            always be casted to a string (if not already a string).
        - If `parse_secret_string_as_json` option is False:
            {SecretString} will be returned as a single entry in the result, with the key being the secret_id.

aws_secrets_manager_secrets_provider.py

Looking down the code the actual option for this should just be json rather than parse_secret_string_as_json

dendraR2 avatar Oct 09 '24 07:10 dendraR2

thanks for the issue! would you like to contribute a PR?

savingoyal avatar Oct 09 '24 19:10 savingoyal

@savingoyal, I have made the changes. Could you please review my pull request?

isatyamks avatar Dec 14 '24 14:12 isatyamks