metaflow icon indicating copy to clipboard operation
metaflow copied to clipboard

Allow option to set labels on pods using `kubernetes` decorator

Open ShantanuKumar opened this issue 1 year ago • 4 comments

We would like to add labels to pod generated using kubernetes decorator. I see there are some internal labels being set by Metaflow but we would like to pass some external ones too.

ShantanuKumar avatar Jun 05 '24 19:06 ShantanuKumar

yes - this has been on our backlog. we had a PR that had to be rolled back due to some issues. stay tuned.

savingoyal avatar Aug 16 '24 06:08 savingoyal

Would this issue be one open to contributions? I've got a use case that requires setting both labels and annotations on the jobs that Metaflow creates.

After going through the source code, I believe I know what updates would need to be made to support those enhancements. Would be happy to put up a PR and work through that, if the team is interested. Not sure if this has already been handled (as the above comment somewhat suggests).

ggutierrez545-ai avatar Oct 21 '24 19:10 ggutierrez545-ai

Pinging again since we also need both label and annotations

ShantanuKumar avatar Dec 17 '24 10:12 ShantanuKumar

#1568 is an inflight PR - if you would like to weigh in with testing that PR that would be great.

On Tue, Dec 17, 2024 at 2:47 AM shan @.***> wrote:

Pinging again since we also need both label and annotations

— Reply to this email directly, view it on GitHub https://github.com/Netflix/metaflow/issues/1880#issuecomment-2548122310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF2MO2GMXLXKVQXDISNPAL2F76KPAVCNFSM6AAAAABI3L2S4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYGEZDEMZRGA . You are receiving this because you commented.Message ID: @.***>

savingoyal avatar Dec 17 '24 13:12 savingoyal