Review afpstats implementation to remove depdenency on dbus-glib

[dgsga]

Potential roadmap for afpstats: Compile afpstats support automatically if dbus and dbus-glib are present (easy, only requires netatalk.m4 macro changes). This would mean that afpstats support would require less user intervention and so make it more accessible. At the moment it needs the two dependencies along with the --with-afpstats configure flag and afpstats=yes in afp.conf

Migrate from the now deprecated dbus-glib to gdbus. I've already done some work on this but haven't got the coding skill to make it work correctly:

https://docs.gtk.org/gio/migrating-gdbus.html https://github.com/dgsga/netatalk/commit/2f935ac7b2275ec1b4d63d397f9497e268d67b8d

@rdmark, what are your thoughts?

[rdmark]

LGTM

I actually forgot that afpstats support has to be enabled at compile time, in addition to runtime. It should be one or the other I think.

Makes sense to compile the feature if the dependencies exist.

[rdmark]

Is dbus-glib going away any time soon? I see no rush to move to a newer library.

[ghost]

Dbus-glib is now deprecated in favour of gdbus,last updated in 2021...

[rdmark]

Ah, that’s important context. The deprecation train keeps on going!

[rdmark]

This was raised in the Debian bug tracker as well: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955927

[rdmark]

For the record, we got some excellent code review feedback from a Debian developer in this now-orphaned commit: https://github.com/Netatalk/netatalk/commit/b860bd8479623c4c5c574cbb46d6094c3a4b77da