Neil Girdhar

Results 395 comments of Neil Girdhar
trafficstars

Not sure if this is the place to comment, but `sigmoid` might be a bad name. "Sigmoid" just means s-shaped. The function should really be called `logistic`: https://en.wikipedia.org/wiki/Logistic_function

@rmorshea Thanks for sharing your thoughts. Feel free to close this since this isn't a real issue :)

@SylvainCorlay I don't know, but the very recent discussion is here: https://mail.python.org/pipermail/python-dev/2016-July/thread.html#145466.

@SylvainCorlay When the PEP is final, it might be worth renaming the methods in traitlets to match the corresponding methods in Python 3.6? And then maybe use a more lightweight...

@SylvainCorlay Awesome. I agree that it would be more elegant if you won't need your custom meta class at all.

So, should `instance_init` be renamed `__set_name__` and not explicitly called in Python 3.6+ (since it is called automatically on all descriptors)? Or `__set_name__` could be defined and could call `instance_init`?

Wait a second, `__set_name__` gets the object and the name. `class_init` gets the class and the name, and `instantce_init` gets the object. It seems like there's a different organization?

This remains broken for me for every jupyter client after 6.1.12.

@davidbrochart Sure. I run jupyter console in a Python 3.9 virtual environment created by poetry and I can't import anything. If I install jupyter-client 6.1.12, the problem goes away.

Just wanted to confirm that https://github.com/jupyter/jupyter_console/pull/244 indeed fixed my problem. Thanks, @davidbrochart !