RevitDBExplorer icon indicating copy to clipboard operation
RevitDBExplorer copied to clipboard

Feature: add inline unit conversion

Open NicoBrown opened this issue 3 years ago • 3 comments

Could a column be added to convert the Revit units into whatever the model is in for readability?

image

Happy to do it and open a pull request if you think its a good idea?

NicoBrown avatar Jul 26 '22 08:07 NicoBrown

What would you say about placing that information in a tooltip?

image

That already is implemented, but there is a bug here: https://github.com/NeVeSpl/RevitDBExplorer/blob/86acb0ba5d84e8b71b910f5d8bebc0853672cc87/sources/WPF/Converters/FeetToMetersConverter.cs#L16

should be typeof(double).GetCSharpName() instead "Double"

PR welcome to fix that, or/and expand the tooltip with more unit conversions.

NeVeSpl avatar Jul 26 '22 10:07 NeVeSpl

I'll take a look at it now and possibly add some more conversions.

If its alright, can I start a Contributions.md at the same time?

NicoBrown avatar Jul 26 '22 11:07 NicoBrown

sure, you can do every not time-consuming change you want without asking, we will be thinking about its fate during PR review.

NeVeSpl avatar Jul 26 '22 14:07 NeVeSpl