nativescript-dev-webpack icon indicating copy to clipboard operation
nativescript-dev-webpack copied to clipboard

CopyWebpackPlugin copies .DS_Store files from App_Resources, ignore hidden files

Open noumaans opened this issue 7 years ago • 1 comments

Issue Checklist

  • [x] You are submitting: a feature request
  • [x] You verified that this is a real problem by searching the [NativeScript Forum] and the other [issues] in this repo.
  • [x] You checked our [demo apps] and the [documentation] for sample usage.

Tell us about the problem

CopyWebPackPlugin copies over hidden files such as .DS_Store files from App_Resources folder.

In webpack.config.js:

            new CopyWebpackPlugin([
              {
                from: `${appResourcesFullPath}/${appResourcesPlatformDir}`,
                to: `${dist}/App_Resources/${appResourcesPlatformDir}`,
                context: projectRoot
              },
            ]),

Webpack output:

clean-webpack-plugin: /Users/.../platforms/ios/nativescript/app/**/* has been removed.
Hash: ...
Version: webpack 3.12.0
Time: 27612ms
                                                                                            Asset       Size  Chunks                    Chunk Names
                                     App_Resources/iOS/Assets.xcassets/refine.imageset/refine.png  454 bytes          [emitted]         
                                                                                        bundle.js    5.42 MB       0  [emitted]  [big]  bundle
                                                                      App_Resources/iOS/.DS_Store    6.15 kB          [emitted]         
                                                      App_Resources/iOS/Assets.xcassets/.DS_Store    6.15 kB          [emitted]         
                                           App_Resources/iOS/Assets.xcassets/add.imageset/add.png  135 bytes          [emitted]         

Local environment

  • [x] Platform Mac
  • [x] Node version 10.2.1
  • [x] NativeScript CLI version 4.0.2

Project data

  • [x] Platform you are building the app for Both
  • [x] Node dependencies:
    "@ngtools/webpack": "^1.10.2",
    "nativescript-css-loader": "^0.26.1",
    "nativescript-dev-appium": "^3.3.0",
    "nativescript-dev-sass": "^1.5.0",
    "nativescript-dev-typescript": "^0.7.1",
    "nativescript-dev-webpack": "^0.11.0",
    "nativescript-worker-loader": "~0.8.1",
    "webpack": "^3.12.0",
    "webpack-bundle-analyzer": "^2.13.1",
    "webpack-sources": "^1.1.0"

noumaans avatar May 28 '18 19:05 noumaans

Hi @noumaans, We reviewed the case and confirm that this is a real problem. Regarding that, any PR, which provides a fix for this problem will be highly appreciated. For further help, you can review our contributing guidelines.

tsonevn avatar Jul 03 '18 09:07 tsonevn