nativescript-cli icon indicating copy to clipboard operation
nativescript-cli copied to clipboard

fix: update plugin gradle script

Open farfromrefug opened this issue 4 years ago • 9 comments

This updates the plugin gradle script:

  • no more android support, use androidx
  • use java 1.8 (removes warning in the console
  • koltin, androidx versions through project properties

farfromrefug avatar Sep 26 '21 14:09 farfromrefug

no more android support, use androidx

Would that be considered a BREAKING CHANGE?

rigor789 avatar Sep 30 '21 17:09 rigor789

Do we still support old versions without androidx?

farfromrefug avatar Sep 30 '21 17:09 farfromrefug

I'm not sure - some plugins may still use it?

rigor789 avatar Sep 30 '21 17:09 rigor789

Seems unlikely. And anyway they can deps on their include.gradle. Honestly we should remove them, plus they end up in the .dat metadata...

farfromrefug avatar Sep 30 '21 17:09 farfromrefug

👍 - just don't want to break things by accident in a patch release

rigor789 avatar Sep 30 '21 17:09 rigor789

@rigor789 i think it should got with android runtime 8.2.0 as we move to gradle 7. But i understand your point

farfromrefug avatar Sep 30 '21 18:09 farfromrefug

@rigor789 @triniwiz that PR now goes further and makes generated plugins aar like 10 times smaller. The consequence is apps dex files getting also much smaller (mine dont even need multidex anymore)

farfromrefug avatar Oct 04 '21 10:10 farfromrefug

All support packages would be jetpacked (if you wanna call it that) .. this looks good for 8.2

triniwiz avatar Oct 04 '21 10:10 triniwiz

superseded by #5774

farfromrefug avatar Jan 17 '24 07:01 farfromrefug