docs-v7 icon indicating copy to clipboard operation
docs-v7 copied to clipboard

docs: Update SDK root in README

Open goonerify opened this issue 4 years ago • 6 comments

Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools

PR Checklist

  • [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
  • [ ] If there is an issue related with this PR, point it out here.

What is the current state of the documentation article?

What is the new state of the documentation article?

Fixes/Implements/Closes #[Issue Number].

goonerify avatar Jan 23 '21 20:01 goonerify

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @goonerify. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] avatar Jan 23 '21 20:01 cla-bot[bot]

@cla-bot check

goonerify avatar Jan 23 '21 20:01 goonerify

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jan 23 '21 20:01 cla-bot[bot]

@cla-bot check

goonerify avatar Jan 23 '21 20:01 goonerify

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jan 23 '21 20:01 cla-bot[bot]

The reason I haven't merged this yet, is that I couldn't confirm the path is correct - since both on Windows & macOS these don't exist (cmdline-tools) and are located at <SDK_ROOT>/tools/bin

rigor789 avatar Feb 15 '21 16:02 rigor789