angular icon indicating copy to clipboard operation
angular copied to clipboard

Modal route issue - route runs twice when returning from second modal containing route outlet

Open JWiseCoder opened this issue 2 years ago • 1 comments

This is most evident in iOS. I've set up a demo app:

https://stackblitz.com/edit/nativescript-stackblitz-templates-vwcmqt

In iOS, if you follow the steps (they're numbered) you'll see that when you navigate back on step five, the animation runs twice—backwards then forwards. This appears to come from the shouldDetach method NSRouteReuseStrategy. If I use the previous code for shouldDetatch that was altered here:

https://github.com/NativeScript/angular/commit/bebcde23c4d6a392638c23ec1e2bc63b06a9b43e

then it works without problem.

NOTE: For this demo, I've used 14.2.6-alpha.0 because without it, I can't use modals with ModalDialogParams because of injector scope issues. However, this router problem described above also occurs in 14.2.5 when the modal corrections are in place. Either way, something isn't working as it should.

JWiseCoder avatar Nov 03 '22 16:11 JWiseCoder

We also have the exact same problem. Rolling back to Angular 14 is the bandaid that did the job for now

Theo-Sioris avatar Jan 13 '23 07:01 Theo-Sioris