android-dts-generator icon indicating copy to clipboard operation
android-dts-generator copied to clipboard

Published 20 hours ago • verified publisher icon NativeScript

fix: wrap invalid JS property names in quotes

Open mukaschultze opened this issue 3 years ago • 3 comments

Some libs (e.g., okhttp) have methods with names that generate invalid typescript code, this PR fixes this by wrapping invalid fields and methods names in quotes

Example:

-		public -deprecated_proxy(): java.net.Proxy;
+		public "-deprecated_proxy"(): java.net.Proxy;

mukaschultze avatar May 11 '22 14:05 mukaschultze

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @mukaschultze. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] avatar May 11 '22 14:05 cla-bot[bot]

@cla-bot check

mukaschultze avatar May 11 '22 14:05 mukaschultze

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar May 11 '22 14:05 cla-bot[bot]