electron icon indicating copy to clipboard operation
electron copied to clipboard

Published 20 hours ago • verified publisher icon NativePHP

Integrate Plugin

Open RobertWesner opened this issue 1 year ago • 2 comments
trafficstars

Implemented the subpath import suggestion.

Relates to #108

Both native:serve and native:build linux x64 worked.

RobertWesner avatar Oct 05 '24 14:10 RobertWesner

The electron-plugin tests give following error:

TypeError: electron_store_1.default is not a constructor

As far as I could reproduce this error existed in the electron-plugin repository before it was integrated. For now they will stay broken since the scope of this pull request is the integration via subpath import, not fixing existing tests.

RobertWesner avatar Oct 05 '24 15:10 RobertWesner

Incredible work! This is a way nicer solution 🙌

I like that the plugin build step can be run from the project root too

gwleuverink avatar Oct 05 '24 19:10 gwleuverink

Thank you both for the kind words! This should work on all platforms but it would probably be wise to test on other systems. As I don't have a macOS device at the moment, I'd appreciate someone confirming this working outside of Linux.

RobertWesner avatar Oct 10 '24 17:10 RobertWesner

IT WORKS!

simonhamp avatar Oct 18 '24 11:10 simonhamp