StackMob-5 icon indicating copy to clipboard operation
StackMob-5 copied to clipboard

StackMob::Event: u.a.s.l.EquipListener (EntityPickupItemEvent) causing performance hit

Open cloakfox opened this issue 4 years ago • 5 comments

https://timings.aikar.co/?id=c3c2b0d160f84b63a63a9284aa2c0765

https://spark.lucko.me/#PdXVSiguqg

Using version 5.4.1

cloakfox avatar Feb 07 '21 15:02 cloakfox

Setting 'events.equip.enabled' to 'false' would fix it, I'll add some extra checks to try a reduce the performance impact. But generally it seems there's a lot of items being dropped (or rather picked up)?

ploppyperson avatar Feb 07 '21 18:02 ploppyperson

Disabling the equip check didnt improve anything at all (with plugin reload)

I've just disabled stackmob as it's not improving performance for us at all.

cloakfox avatar Feb 08 '21 11:02 cloakfox

with '/sm reload'? you'd have to restart the server for it to take effect.

ploppyperson avatar Feb 08 '21 13:02 ploppyperson

Yes I used /stackmob reload.

Im no longer using a stacker plugin, they cause more lag then they prevent.

cloakfox avatar Feb 08 '21 13:02 cloakfox

Yes I used /stackmob reload.

Im no longer using a stacker plugin, they cause more lag then they prevent.

Right, they cause lag, however they prevent more lag if correctly used and in a judicious way, with config options that could cause issues for example ^^

Aurelien30000 avatar Feb 08 '21 18:02 Aurelien30000