Nancy icon indicating copy to clipboard operation
Nancy copied to clipboard

Published 20 hours ago • verified publisher icon NancyFx

Update to Net-standard 2.1 and update test project NuGet packages

Open 0x414c49 opened this issue 5 years ago • 9 comments

Prerequisites

  • [x] I have written a descriptive pull-request title
  • [x] I have verified that there are no overlapping pull-requests open
  • [x] I have verified that I am following the Nancy code style guidelines
  • [x] I have provided test coverage for my change (where applicable)

Description

The projects are targeted to .NET Standard 2.1, 2.0 and .NET 4.5.2. Due to this change minimum version of the SDK project changed to 3.1.102 -> rollForward minor.

The AsyncUsageAnalyzers is not supported in .NET Standard 2.1 and it's outdated. I replaced it with Microsoft.VisualStudio.Threading.Analyzers package.

FakeItEasy, XUnit and Microsoft Test Framework SDK are updated to the latest version.

This PR will resolve #3007

0x414c49 avatar Mar 11 '20 13:03 0x414c49

Builds are failing on Travis and AppVeyor because of the .NET SDK and Mono version. I need to see how to fix them.

0x414c49 avatar Mar 11 '20 13:03 0x414c49

  • Travis-ci: Distro has changed to Ubuntu bionic, Mono changed to 6.8.0 and dotnet SDK to 3.1.102
  • Appveyor: image changed to VS2019
  • PowerShell script: CakeVersion updated to 0.37.0
  • Bash script: DOTNET_INSTALL_URL updated
  • For both PowerShell and bash, there was a bug in regex that couldn't detect versions like x.x.x00.
  • Cake: The project is using dotnet test command. xunit command replaced with test command and arguments changed to match dotnet test command.
  • xunit.runner.visualstudio (2.4.1) will run the jobs for dotnet test command. Microsoft.NET.Test.Sdk version changed to 15.5.0 from 16.5.0. The 16.5.0 version didn't copy testhost.dll to the output.

AppVeyor pipeline is passing now, there is a problem with Travis in OSXand Linux. I need to investigate more.

0x414c49 avatar Mar 12 '20 11:03 0x414c49

There is something interesting, Travis CI now supports .NET SDK 3.x.x by default. Why do we need to install it again?

0x414c49 avatar Mar 12 '20 12:03 0x414c49

By replacing AsyncUsageAnalyzers with Microsoft.VisualStudio.Threading.Analyzers there are +500 warnings about async usages. They are mostly in test projects.

0x414c49 avatar Mar 12 '20 13:03 0x414c49

The pipelines now compile fine. The tests are running fine Linux, OSX and on a local-machine. BrowserFixture.Should_return_JSON_serialized_form is failing on AppVeyor.

0x414c49 avatar Mar 12 '20 13:03 0x414c49

I don't know why. I have a parallel test on my own AppVeyor account. The tests are passing fine there!

image

0x414c49 avatar Mar 12 '20 13:03 0x414c49

By rerunning the build, everything works fine.

0x414c49 avatar Mar 12 '20 14:03 0x414c49

Why target .NET Standard 2.1? Nancy's not using any APIs from the standard. I'm failing to see what value it brings.

khellang avatar Mar 13 '20 07:03 khellang

@khellang you are right about the APIs. It's not a must but shouldn't keep the project updated to be able to use the latest APIs? like support for Span<T> in case of refactoring for memory, CPU performance?

0x414c49 avatar Mar 13 '20 07:03 0x414c49