Nancy.Bootstrappers.Ninject icon indicating copy to clipboard operation
Nancy.Bootstrappers.Ninject copied to clipboard

Remove the FactoryModule (replaced by Ninject.Extensions.Factory) and fix unit tests

Open scott-xu opened this issue 11 years ago • 4 comments

scott-xu avatar Jan 26 '14 12:01 scott-xu

This would be a breaking change as user need to refer Ninject.Extensions.Factory if they used/will use Func<>. Where can I document this?

scott-xu avatar Jan 26 '14 12:01 scott-xu

I'm not sure I'd classify this a a breaking change. It's just a new dependency and we don't have to change public APIs because of it. The question is; why is it there in the first place? Do we use Func<T> factories anywhere? @thecodejunkie, @grumpydev? If we do, then this gets my :+1:

khellang avatar Sep 08 '14 21:09 khellang

@khellang Func<T> is used at least in RouteCache https://github.com/NancyFx/Nancy/blob/master/src/Nancy/Routing/DefaultRouteCacheProvider.cs#L46

scott-xu avatar Sep 10 '14 08:09 scott-xu

Hi @thecodejunkie @grumpydev, what do you think about this?

scott-xu avatar Sep 12 '14 17:09 scott-xu