Nameless icon indicating copy to clipboard operation
Nameless copied to clipboard

Published 20 hours ago • verified publisher icon NamelessMC

Move `ROOT_PATH` constant to a class

Open Derkades opened this issue 2 years ago • 1 comments

Why?

  • It no longer needs to be set manually (like in CLI installer, seeder, etc), reducing the possibility of errors when files are moved
  • Tools like phpstan do not like global constants

Derkades avatar Feb 02 '23 20:02 Derkades

I think we should keep the ROOT_PATH constant for 2.1.0, and then remove it in 2.2.0 - just to spread out the massive breaking changes a bit for module devs

tadhgboyle avatar Feb 09 '23 21:02 tadhgboyle