open-gpu-kernel-modules icon indicating copy to clipboard operation
open-gpu-kernel-modules copied to clipboard

silence double free warning

Open trixirt opened this issue 3 years ago • 6 comments

clang static analysis reports this issue on RHEL open-gpu-kernel-modules/kernel-open/nvidia/nv.c:1392:9: warning: Attempt to free released memory [unix.Malloc] NV_KFREE(nvl->irq_count, nvl->num_intr*sizeof(nv_irq_count_info_t)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a false positive, NV_FLAG_USES_MSIX and NV_FLAG_USES_MSI are mutually exclusive. Convert the NV_FLAG_USE_MSIX 'if' to an 'if else'

Signed-off-by: Tom Rix [email protected]

trixirt avatar May 15 '22 13:05 trixirt

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tom Rix seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 15 '22 13:05 CLAassistant

Hey Tom, thank you for your contrib. We'll need the CLA signed to pull this into internal SCM.

niv avatar May 16 '22 12:05 niv

CLA has been signed, anything else ?

trixirt avatar Jun 15 '22 20:06 trixirt

Hi! Thanks for checking back. I was out for a bit, but I'll handle it soon. This hasn't been forgotten.

niv avatar Jun 17 '22 17:06 niv

PR has stalled

trixirt avatar Jul 14 '22 12:07 trixirt

Hi tom,

the change has bee applied internally, and will bubble up in a future release, at which point this PR will also go in. Same reasoning/details as explained in https://github.com/NVIDIA/open-gpu-kernel-modules/pull/330#issuecomment-1203811765.

Thanks for your contribution, and patience!

niv avatar Aug 11 '22 14:08 niv