open-gpu-kernel-modules
open-gpu-kernel-modules copied to clipboard
silence double free warning
clang static analysis reports this issue on RHEL open-gpu-kernel-modules/kernel-open/nvidia/nv.c:1392:9: warning: Attempt to free released memory [unix.Malloc] NV_KFREE(nvl->irq_count, nvl->num_intr*sizeof(nv_irq_count_info_t)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is a false positive, NV_FLAG_USES_MSIX and NV_FLAG_USES_MSI are mutually exclusive. Convert the NV_FLAG_USE_MSIX 'if' to an 'if else'
Signed-off-by: Tom Rix [email protected]
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Tom Rix seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hey Tom, thank you for your contrib. We'll need the CLA signed to pull this into internal SCM.
CLA has been signed, anything else ?
Hi! Thanks for checking back. I was out for a bit, but I'll handle it soon. This hasn't been forgotten.
PR has stalled
Hi tom,
the change has bee applied internally, and will bubble up in a future release, at which point this PR will also go in. Same reasoning/details as explained in https://github.com/NVIDIA/open-gpu-kernel-modules/pull/330#issuecomment-1203811765.
Thanks for your contribution, and patience!