cuCollections icon indicating copy to clipboard operation
cuCollections copied to clipboard

Switch to cuda::std::span once available

Open sleeepyjack opened this issue 2 years ago • 3 comments

Our hash function implementations currently make use of the following function signature:

template <typename Extent>
constexpr result_type __host__ __device__ compute_bytes(std::byte const* data, Extent size) const noexcept

We should switch to cuda::std::span instead of raw pointers, once rapidsai/rapids-cmake#399 is resolved.

sleeepyjack avatar Jul 10 '23 14:07 sleeepyjack

Using cuda::std::span may lose the benefit of the static extent.

PointKernel avatar Jul 10 '23 17:07 PointKernel

Span supports a static extent as a second size_t tparam - though not as elegant as our extent type. Since compute_hash is user-facing, it's better to require a proper span argument rather than a raw pointer and size.

sleeepyjack avatar Jul 10 '23 18:07 sleeepyjack

@sleeepyjack Is this still desired?

PointKernel avatar Aug 06 '24 21:08 PointKernel