TransformerEngine
TransformerEngine copied to clipboard
[UB] Fixing consistency of error messages.
Description
Making sure that the UB timeouts have consistent error messaging
Fixes # (issue)
Type of change
- [ ] Documentation change (change only to the documentation, either a fix or a new content)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Changes
Please list the changes introduced in this PR:
- Fixing error messaging to provide consistent output to simplify the work of log parsers
Checklist:
- [x] I have read and followed the contributing guidelines
- [x] The functionality is complete
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
The changes are reasonable, but we are in the process of moving Userbuffers to the common library: https://github.com/NVIDIA/TransformerEngine/pull/760
Pinging @denera
Yes, I was able to get everything working for PR #760 yesterday. I'm doing some final code cleanup at the moment and hope to merge it next week after final review, performance validations and CI testing.
Thanks @denera - can we go ahead and merge ?