TensorRT icon indicating copy to clipboard operation
TensorRT copied to clipboard

NvInferRuntimeCommon.h is #included in sample code

Open carlosgalvezp opened this issue 2 years ago • 3 comments

Hi,

NvInferRuntimeCommon.h clearly states that it must not be included:

//! \warning Do not directly include this file. Instead include NvInferRuntime.h

However, it's included in many places in the samples directory, for example here.

I take it that NvInferRuntimeCommon.h is an implementation detail and thus we clients should not include it directly. Could therefore the samples be updated to reflect best practices?

Thanks!

carlosgalvezp avatar Oct 04 '23 11:10 carlosgalvezp

@rajeevsrao ^ ^

zerollzeng avatar Oct 05 '23 15:10 zerollzeng

@zerollzeng could you file a bug to track this? thanks!

ttyio avatar Dec 05 '23 21:12 ttyio

Filed internal bug 4411864 to track

zerollzeng avatar Dec 09 '23 08:12 zerollzeng

this is fixed in rel-10.0, see https://github.com/NVIDIA/TensorRT/blob/release/10.0/samples/common/ErrorRecorder.h,

closing and thanks all!

ttyio avatar Apr 30 '24 20:04 ttyio