NeMo-text-processing icon indicating copy to clipboard operation
NeMo-text-processing copied to clipboard

Add Korean TN support for cardinal numbers and postprocessing

Open bbae0312 opened this issue 5 months ago • 0 comments

What does this PR do ?

Classify and verbalize grammars Unit tests with coverage up to 17-digit numbers Support for spacing around units (억, 만, 조, 경) Post-processing logic for formatting Unit tests and Sparrowhawk tests

Before your PR is "Ready for review"

Pre checks:

  • [x ] Have you signed your commits? Use git commit -s to sign.
  • [x ] Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • [x ] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • [x ] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • [x ] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • [x ] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • [x ] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • [x ] Remove import guards (try import: ... except: ...) if not already done.
  • [x ] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • [x ] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • [x ] New Feature
  • [ ] Bugfix
  • [ ] Documentation
  • [ ] Test

If you haven't finished some of the above items you can still open "Draft" PR.

bbae0312 avatar May 21 '25 22:05 bbae0312