NeMo-text-processing icon indicating copy to clipboard operation
NeMo-text-processing copied to clipboard

remove subsitiution of a state code to state name

Open pirchi1 opened this issue 1 year ago • 2 comments

…t a otional space anf than acronym of a US state in the replacement the state acronym is replaced with the state full name, e.g. d, NC -> , North Carolania

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • [ ] Have you signed your commits? Use git commit -s to sign.
  • [ ] Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • [ ] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • [ ] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • [ ] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • [ ] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • [ ] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • [ ] Remove import guards (try import: ... except: ...) if not already done.
  • [ ] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • [ ] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation
  • [ ] Test

If you haven't finished some of the above items you can still open "Draft" PR.

pirchi1 avatar Apr 14 '24 12:04 pirchi1

@pirchi1 why do you suggest removing states abbreviation expansion?

ekmb avatar Apr 16 '24 19:04 ekmb

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar May 01 '24 01:05 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar May 09 '24 01:05 github-actions[bot]