NeMo-text-processing icon indicating copy to clipboard operation
NeMo-text-processing copied to clipboard

Jp itn

Open BuyuanCui opened this issue 2 years ago • 10 comments

What does this PR do ?

Merge to main for Japanese support on cardinal, ordinal, time, date, fraction, decimal support Add a one line overview of what this PR aims to accomplish. This is a PR for Japanese ITN support.

Before your PR is "Ready for review"

Pre checks:

  • [*] Have you signed your commits? Use git commit -s to sign.
  • [*] Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • [*] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • [*] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • [*] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • [*] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • [*] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • [*] Remove import guards (try import: ... except: ...) if not already done.
  • [*] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • [*] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • [*] New Feature
  • [ ] Bugfix
  • [ ] Documentation
  • [ ] Test

If you haven't finished some of the above items you can still open "Draft" PR.

BuyuanCui avatar Sep 07 '23 17:09 BuyuanCui

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Oct 25 '23 01:10 github-actions[bot]

@BuyuanCui I reviewed the latest codes and it's almost OK. But, I'm so sorry that it looks like I missed one more thing.

So far, the package and directory names include jp like nemo_text_processing/inverse_text_normalization/jp/__init__.py, but I think it would be better to be the same with a standard language code (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes). Would it be necessary to follow this standard? If yes, it should be changed to ja. If not, please ignore this.

So sorry again for this late comment. There's no additional thing except for this. Thanks.

lazykyama avatar Oct 25 '23 05:10 lazykyama

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Nov 28 '23 01:11 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Dec 05 '23 01:12 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Dec 28 '23 01:12 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Jan 18 '24 01:01 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Feb 08 '24 01:02 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Mar 08 '24 01:03 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Mar 15 '24 01:03 github-actions[bot]

@BuyuanCui should we close this PR in favor of https://github.com/NVIDIA/NeMo-text-processing/pull/141 ?

ekmb avatar Apr 30 '24 18:04 ekmb

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar May 15 '24 01:05 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar May 23 '24 01:05 github-actions[bot]