NeMo-Guardrails icon indicating copy to clipboard operation
NeMo-Guardrails copied to clipboard

Guard as action

Open zsimjee opened this issue 1 year ago • 3 comments

Description

This PR contains helper functions and docs that show nemoguardrails users how to use Guardrails AI-style validation in their nemoguardrails code flow.

Related Issue(s)

N/A

Checklist

  • [x] I've read the CONTRIBUTING guidelines.
  • [x] I've updated the documentation if applicable.
  • [x] (N/A) I've added tests if applicable.
  • [x] @mentions of the person or team responsible for reviewing proposed changes.

zsimjee avatar Oct 17 '24 23:10 zsimjee

@Pouyanpi, this is one half of the upcoming integration with Guardrails AI -- they've got the other half on their side. https://www.guardrailsai.com/

cparisien avatar Oct 31 '24 15:10 cparisien

Hi @zsimjee, is your PR ready for review? If it is, please mark it as ready for review. Thanks 👍

Pouyanpi avatar Nov 06 '24 15:11 Pouyanpi

Hi @zsimjee, thank you for making further improvements.

I think there are still gaps that I will comment later.

I believe the way that the integration is being done is not consistent, and we should avoid breaking consistency. I still think my previous comments are valid and I think the best way to integrate Guardrails AI is similar to content safety check there you are not bound to one content safety model, I don't see it to fit where langchain stands wrt NeMo Guardrails.

I will provide suggestions later, but for example following incompatibality needs to be addressed with current implementation:

nemoguardrails chat --config=./examples/configs/guardrailsai
Starting the chat (Press Ctrl + C twice to quit) ...
Fetching 5 files: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5/5 [00:00<00:00, 18724.57it/s]

> Who is the current president of the United States, and what was their email address?
Action 'pii_guard_validate' not found.

In the meantime, please rebase the branch to develop. Note that the docs directory was restructured and we now use poetry (see contributing guide)

Pouyanpi avatar Jan 09 '25 15:01 Pouyanpi

@Pouyanpi @tgasser-nv This is ready for review again, Zayd made some key updates to the integration.

cparisien avatar May 21 '25 19:05 cparisien

close it in favor of #1298

Pouyanpi avatar Oct 13 '25 13:10 Pouyanpi