NeMo-Guardrails icon indicating copy to clipboard operation
NeMo-Guardrails copied to clipboard

feat: Add Azure OpenAI embedding provider

Open shubhiroy opened this issue 1 year ago • 1 comments
trafficstars

Added support for azure open ai embedding model.

shubhiroy avatar Aug 26 '24 12:08 shubhiroy

@shubhiroy it seems that your PR was pending review for a while, thanks for being patient 👍🏻

Is it possible for you to rebase it to develop branch? I'm not sure if you have noticed but the repo has changed quite significantly since the PR was opened. Also dev workflow has changed a bit (see contributing guide). Let's start by resolving the conflict first.

Pouyanpi avatar Jan 09 '25 13:01 Pouyanpi

Codecov Report

Attention: Patch coverage is 40.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.07%. Comparing base (8575b88) to head (e449600).

Files with missing lines Patch % Lines
nemoguardrails/embeddings/providers/azureopenai.py 36.36% 21 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #702      +/-   ##
===========================================
- Coverage    70.13%   70.07%   -0.07%     
===========================================
  Files          161      162       +1     
  Lines        16037    16071      +34     
===========================================
+ Hits         11248    11261      +13     
- Misses        4789     4810      +21     
Flag Coverage Δ
python 70.07% <40.00%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
nemoguardrails/embeddings/providers/__init__.py 96.42% <100.00%> (+0.13%) :arrow_up:
nemoguardrails/embeddings/providers/azureopenai.py 36.36% <36.36%> (ø)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jul 14 '25 14:07 codecov-commenter

Thank you again @shubhiroy I will take over your PR so that we can merge it for 0.18.0.

once #1446 is merged I'll add AzureOpenAI tests and we should be good to merge.

Pouyanpi avatar Oct 13 '25 13:10 Pouyanpi

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov-commenter avatar Oct 13 '25 13:10 codecov-commenter