NeMo-Curator icon indicating copy to clipboard operation
NeMo-Curator copied to clipboard

Ruff Bug fixes in code

Open praateekmahajan opened this issue 7 months ago • 0 comments
trafficstars

Describe the bug

While incorporating Ruff, we noticed a few code paths that are buggy. This master issue aims to capture the list of them, so that we can resolve them one at a time

  • [ ] tutorials/synthetic-retrieval-evaluation/ - Endpoints.py undeclared fetch_url_format and headers - Rename files and classes to follow python standards (no capitalized filenames, classes with _`)
  • [ ] nemo_curator/modules/task.py trimmed variable never used
  • [ ] tutorials/nemo-retriever-synthetic-data-generation/retriever_evalset_generator.py _get_random_hash never uses question
  • [ ] tutorials/nemotron-cc :
    • nemotron_cc.ipynb undeclared variable remove_ex
    • nemotron_cc.ipynb consolidate ways a dask cluster is started
  • [ ] tests/utils/test_distributed_utils : test_get_client unused mock_gpu_cluster (tho it should be used)

praateekmahajan avatar Apr 04 '25 22:04 praateekmahajan