Megatron-LM icon indicating copy to clipboard operation
Megatron-LM copied to clipboard

feat: Apply RoPE embedding with sequence offsets

Open sudhakarsingh27 opened this issue 1 week ago • 4 comments

What does this PR do ?

Allows applying rope embedding with "offsets" to sequences in packed (thd) or batch (bshd/sbhd) formats. The offset per sequence can be supplied as an argument start_positions tensor.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]

Pre-checks

  • [ ] I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • [ ] I have added relevant unit tests
  • [ ] I have added relevant functional tests
  • [ ] I have added proper typing to my code Typing guidelines
  • [ ] I have added relevant documentation
  • [ ] I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

:warning: Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

sudhakarsingh27 avatar Nov 26 '25 23:11 sudhakarsingh27

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Nov 26 '25 23:11 copy-pr-bot[bot]

/ok to test c3e83ad3c03c0de8771a2db7c2a66c23a1486f9f

deepakn94 avatar Nov 26 '25 23:11 deepakn94

/ok to test

sudhakarsingh27 avatar Nov 26 '25 23:11 sudhakarsingh27

/ok to test https://github.com/NVIDIA/Megatron-LM/pull/2416/commits/f0461ab06bf97267d25abf30b73686e31d3969f0

sudhakarsingh27 avatar Nov 26 '25 23:11 sudhakarsingh27