Megatron-LM icon indicating copy to clipboard operation
Megatron-LM copied to clipboard

Fix `ImportError` and `NameError` in `examples/run_simple_mcore_train_loop.py`

Open marksverdhei opened this issue 1 month ago • 8 comments

What does this PR do ?

This PR fixes two breaking bugs (ImportError and NameError) in examples/run_simple_train_loop.py that were introduced when type hints were added.

Resolves #1979

Pre-checks

  • [ ] I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • [ ] I have added relevant unit tests
  • [ ] I have added relevant functional tests
  • [x] I have added proper typing to my code Typing guidelines
  • [x] I have added relevant documentation
  • [ ] I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

:warning: Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

marksverdhei avatar Oct 27 '25 17:10 marksverdhei

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Oct 27 '25 17:10 copy-pr-bot[bot]

@ananthsub Should this be merged?

marksverdhei avatar Nov 10 '25 11:11 marksverdhei

@ananthsub Should this be merged?

please merge

simondong1 avatar Nov 19 '25 10:11 simondong1

/ok to test ee29372652a2114118e2b9c56d719d7ebdecce2e

theothermike avatar Nov 26 '25 14:11 theothermike

/ok to test 518bb1f7f272d399f113de233bbb8e59ffacf2c7

theothermike avatar Nov 26 '25 15:11 theothermike

/ok to test 47652b01ff036d64f447a6af0f9f724a8c0f2091

theothermike avatar Nov 27 '25 21:11 theothermike

/ok to test 5c8f311aa4f62378d153934aaf3215b9651c96cb

theothermike avatar Nov 28 '25 13:11 theothermike

/ok to test 1130e28397277897efd11b539ef05d781d1a256b

theothermike avatar Nov 30 '25 14:11 theothermike

/ok to test 8373b7a

chtruong814 avatar Dec 01 '25 15:12 chtruong814

Thank you for your contribution!

NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process.

Thank you for your understanding.

github-actions[bot] avatar Dec 01 '25 15:12 github-actions[bot]

image

marksverdhei avatar Dec 03 '25 15:12 marksverdhei