Megatron-LM icon indicating copy to clipboard operation
Megatron-LM copied to clipboard

MuonClip support (non-split version)

Open BoxiangW opened this issue 1 month ago • 11 comments

Added MLA and MHA(GQA) clipping support

BoxiangW avatar Oct 24 '25 22:10 BoxiangW

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Oct 24 '25 22:10 copy-pr-bot[bot]

TE's https://github.com/NVIDIA/TransformerEngine/pull/2195 (2.9.0) is needed for this PR

BoxiangW avatar Oct 24 '25 22:10 BoxiangW

TE's NVIDIA/TransformerEngine#2195 (2.9.0) is needed for this PR

It has been merged.

skyw avatar Oct 28 '25 23:10 skyw

/ok to test 7917e68

BoxiangW avatar Nov 03 '25 06:11 BoxiangW

/ok to test 495f58d

BoxiangW avatar Nov 03 '25 21:11 BoxiangW

/ok to test 55cc00d

BoxiangW avatar Nov 04 '25 16:11 BoxiangW

/ok to test 9095615

BoxiangW avatar Nov 05 '25 00:11 BoxiangW

Boxiang, I suppose you need someone in the expert reviewer list to review.

skyw avatar Nov 07 '25 16:11 skyw

/ok to test 1bb0407

BoxiangW avatar Nov 10 '25 19:11 BoxiangW

/ok to test b63c573

BoxiangW avatar Nov 10 '25 19:11 BoxiangW

/ok to test 95fdba3

BoxiangW avatar Nov 20 '25 09:11 BoxiangW

Can we re-name this PR? It should just be "QK logits clipping" or something similar?

deepakn94 avatar Nov 30 '25 17:11 deepakn94

/ok to test 6562a52

BoxiangW avatar Dec 03 '25 18:12 BoxiangW